Disable red pin for Viewer Work Order Details page #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateoclarke
approved these changes
Jul 19, 2019
knack/iframeMapMessenger.js
Outdated
| @@ -34,7 +34,7 @@ | |||
| // Add React app as iframe if iframe doesn't already exist | |||
| if ($(myView + " #mapIFrame").length === 0) { | |||
| $( | |||
| '<iframe src="https://atd-geo-knack-ui.netlify.com/" frameborder="0" scrolling="yes" id="mapIFrame" \ | |||
| '<iframe src="https://localhost:9001/" frameborder="0" scrolling="yes" id="mapIFrame" \ | |||
There was a problem hiding this comment.
I don't think we want this referencing localhost in prod right @mddilley?
There was a problem hiding this comment.
Right now in the knack js code (index.js), it references the "https://dnb4pix4gcpf6.cloudfront.net/atd-knack-signs-markings/98_marker_render/iframeMapMessenger.js". Do we need to update that?
There was a problem hiding this comment.
Good catch! Just changed and pushed. I'll update the Knack JS in builder with the latest from master after merging this branch.
| @@ -368,6 +369,10 @@ export default class SelectLocation extends Component { | |||
|
|
|||
| switch (data.message) { | |||
| case "SIGNS_API_REQUEST": | |||
| // Use workOrderDetailsViewable state to disable red pin and pulse if user is Viewer role | |||
| if (data.view === "view_2619") { | |||
There was a problem hiding this comment.
Nice, this is pretty clever. Kinda of a hard-coded hack but let's count our wins and never talk about this again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #103