Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moped Tables | Implement basic table #4784 #169

Merged
merged 41 commits into from Dec 28, 2020
Merged

Conversation

sergiogcx
Copy link
Contributor

@sergiogcx sergiogcx commented Dec 28, 2020

Implements initial GridTable component

  • Makes full use of GQLAbstract library
  • Displays columns according to configuration
  • Implements pagination
  • Implements sorting

Closes cityofaustin/atd-data-tech#4784

** IT REQUIRES THE LATEST VERSION OF THE GQLAbstract LIBRARY, BEFORE YOU RUN, BE SURE TO UPDATE YOUR ATD-KICKSTAND LIBRARY IN YOUR LOCAL ENVIRONMENT **

During development, I came across an underlying issue with Apollo caching and I still could not pinpoint the issue after a couple hours trying to figure it out. This issue has been created to troubleshoot caching in the future.
cityofaustin/atd-data-tech#4788

@sergiogcx sergiogcx added the WIP Work in progress label Dec 28, 2020
Copy link
Contributor

@mateoclarke mateoclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code looks excellent. Really appreciate all the organization and comments. The only feedback I have is visual and I'm fine doing that as a separate styling focused pass later on if you prefer for me too add these comments as a backlog issue to revisit later.

  1. Padding around the loading spinner. I think the spinner could use a little room to breathe here. Could even see it being centered.

Screen Shot 2020-12-28 at 2 40 08 PM

  1. The alignment of the sort arrow and the way the text wraps looks a little off visually.

Screen Shot 2020-12-28 at 2 40 15 PM

Maybe the example from the Material UI <DataGrid> component could be a good example to look at.

Screen Shot 2020-12-28 at 2 46 11 PM

Material-Table also has some good examples for visual inspiration.

  1. I couldn't get a screengrab of this but I would only expect the column headers that are sortable to show the cursor: pointer on hover. The rest that aren't sortable, I would expect a more default cursor. The pointer implies there is interactivity.

@sergiogcx sergiogcx merged commit 5c35318 into main Dec 28, 2020
@sergiogcx sergiogcx deleted the 4746-sg-gridtable branch December 28, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moped Tables | Implement basic table
2 participants