-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moped Tables | Implement basic table #4784 #169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code looks excellent. Really appreciate all the organization and comments. The only feedback I have is visual and I'm fine doing that as a separate styling focused pass later on if you prefer for me too add these comments as a backlog issue to revisit later.
- Padding around the loading spinner. I think the spinner could use a little room to breathe here. Could even see it being centered.
- The alignment of the sort arrow and the way the text wraps looks a little off visually.
Maybe the example from the Material UI <DataGrid>
component could be a good example to look at.
Material-Table also has some good examples for visual inspiration.
- I couldn't get a screengrab of this but I would only expect the column headers that are sortable to show the
cursor: pointer
on hover. The rest that aren't sortable, I would expect a more default cursor. The pointer implies there is interactivity.
Implements initial GridTable component
Closes cityofaustin/atd-data-tech#4784
** IT REQUIRES THE LATEST VERSION OF THE GQLAbstract LIBRARY, BEFORE YOU RUN, BE SURE TO UPDATE YOUR ATD-KICKSTAND LIBRARY IN YOUR LOCAL ENVIRONMENT **
During development, I came across an underlying issue with Apollo caching and I still could not pinpoint the issue after a couple hours trying to figure it out. This issue has been created to troubleshoot caching in the future.
cityofaustin/atd-data-tech#4788