State management | Migrate to Apollo Client 3.0 #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiogcx
approved these changes
Jan 20, 2021
sergiogcx
reviewed
Jan 20, 2021
Comment on lines
+26
to
+48
| // https://www.apollographql.com/docs/react/networking/authentication/#header | ||
| const httpLink = createHttpLink({ uri: HASURA_ENDPOINT }); | ||
|
|
||
| const authLink = setContext((_, { headers }) => { | ||
| // Get the authentication token and role from user if it exists | ||
| const token = getJwt(user); | ||
| const role = getHighestRole(user); | ||
|
|
||
| // Return the headers and role to the context so httpLink can read them | ||
| return { | ||
| headers: { | ||
| ...headers, | ||
| authorization: token ? `Bearer ${token}` : "", | ||
| "x-hasura-role": role ? role : "", | ||
| }, | ||
| }; | ||
| }); | ||
|
|
||
| const client = new ApolloClient({ | ||
| // Join authLink and httpLink to handle auth in each request | ||
| link: authLink.concat(httpLink), | ||
| cache: new InMemoryCache(), | ||
| }); |
There was a problem hiding this comment.
Thanks for explaining how Apollo Links work! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes cityofaustin/atd-data-tech#4758
This PR updates Apollo Client and all of the imports throughout the app. I left
apollo-boostas a dependency since it is required by the GraphQL abstract inatd-kickstand. I also updated the way that the request headers and user role are appended to requests by following this Apollo snippet. I tested multiple roles and checked the request headers for the JWT and role for Hasura, and it works well.I also am unable to replicate the caching bug from cityofaustin/atd-data-tech#4788 in this branch so I removed the notes about the bug and set
cache-firstfetch policies in both Project and Staff GridTable configs.Request headers from the React app