Update event triggers for moped personnel and personnel roles #964

chiaberry · 2023-02-01T22:33:18Z

Associated issues

Testing

URL to test:
https://deploy-preview-964--atd-moped-main.netlify.app/moped/projects

Steps to test:

Add team members to a team
Remove a team member
Swap out one team member for a different name
Do any other edits you can to a team member

Changing roles are tracked in the activity log, but aren't shown in the UI. You can check that the mutations are working locally by checking http://localhost:9695/console/events/data/activity_log_moped_proj_personnel_roles/processed or querying the db.

I also have a note about a bug I saw in staging where if you save empty spaces as a project description, you can't edit the description again (ex: https://moped.austinmobility.io/moped/projects/1790). Try saving a description as " " and you should see the "-" render so you can still edit the field.

Ship list

Code reviewed
Product manager approved
Added to QA test script if applicable

chiaberry · 2023-02-02T02:47:16Z

moped-database/metadata/tables.yaml

+                                    "record_type":  {{ $body.table.name }},
+                                    "activity_id": {{ $body.id }},
+                                    "record_data": { "event": {{ $body.event }}},
+                                    "record_project_id": null,


moped_proj_personnel_roles does not have a column for the project_id, so this is null. This also means that while we are tracking these activities, they will not show up in our activity log query since we query on project_id

this is great—thanks for getting the tracking in place.

i also want to point out that, because we don't have the project ID here, we cannot update the project's modified date through this mutation. that's frustrating because i think user's should be able to expect that any project edit will update the project's modified date. if we wanted to get clever, we could mutate the moped_proj_personnel record from here, which would then fire off another event which would mutate the parent project's modified date. that would require us adding some mutable field on moped_proj_personnel like an updated_at timestamp.

just throwing it out there—i don't necessarily think this is a good idea. i believe we're also going to encounter this problem when we set up tracking for project features.

chiaberry · 2023-02-02T02:58:51Z

moped-editor/src/views/projects/projectView/ProjectSummary/ProjectSummaryProjectDescription.js

@@ -114,7 +114,7 @@ const ProjectSummaryProjectDescription = ({
        )}
        {!editMode && (
          <ProjectSummaryLabel
-            text={description || " - "}
+            text={description.trim().length > 0 ? description : " - "}


This is to fix a bug I found where if you save empty spaces as a project description, you can't edit the description again (ex: https://moped.austinmobility.io/moped/projects/1790) Boolean(" ") is true.

thank you for fixing this!

we have a snackoo to prevent users from saving an empty description in the first place. we require description on project create but not project edit.

chiaberry · 2023-02-02T03:09:23Z

moped-editor/src/utils/activityLogFormatters/mopedProjectActivity.js

@@ -95,7 +95,6 @@ export const formatProjectActivity = (change, lookupList) => {
        ],
      };
    }
-    console.log(changeData.new[changedField])


johnclary

looks great and works great! since you're out-of-electricity i made a tiny patch to rework the edit event text.

🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢

johnclary · 2023-02-02T15:25:53Z

moped-database/metadata/tables.yaml

+                                    "record_type":  {{ $body.table.name }},
+                                    "activity_id": {{ $body.id }},
+                                    "record_data": { "event": {{ $body.event }}},
+                                    "record_project_id": null,


this is great—thanks for getting the tracking in place.

i also want to point out that, because we don't have the project ID here, we cannot update the project's modified date through this mutation. that's frustrating because i think user's should be able to expect that any project edit will update the project's modified date. if we wanted to get clever, we could mutate the moped_proj_personnel record from here, which would then fire off another event which would mutate the parent project's modified date. that would require us adding some mutable field on moped_proj_personnel like an updated_at timestamp.

just throwing it out there—i don't necessarily think this is a good idea. i believe we're also going to encounter this problem when we set up tracking for project features.

johnclary · 2023-02-02T15:33:06Z

moped-editor/src/views/projects/projectView/ProjectActivityEntry.js

+        <Typography
+          variant="body2"
+          className={classes.entryText}
+          component="span"


this fixes an invalid DOM nesting error

thank you!!!

johnclary · 2023-02-02T15:34:38Z

moped-editor/src/views/projects/projectView/ProjectSummary/ProjectSummaryProjectDescription.js

@@ -114,7 +114,7 @@ const ProjectSummaryProjectDescription = ({
        )}
        {!editMode && (
          <ProjectSummaryLabel
-            text={description || " - "}
+            text={description.trim().length > 0 ? description : " - "}


thank you for fixing this!

we have a snackoo to prevent users from saving an empty description in the first place. we require description on project create but not project edit.

mddilley

Tried all things personnel, and it works like a dream! 🙌 Some cool bug fixes in here too. 👋 🐛 Seeing rich events like Replaced team member <team member> with <team member> really makes this activity log look so pro!!! 🚢

chiaberry added 12 commits January 26, 2023 14:49

make it so you can edit empty descriptions

699783a

add personnel to rest connector

e97d537

fix merge conflict

5d9e5d4

fix the env variable

1995e98

add personnel activity log for adding user and replacing

90bfa2e

Fix merge conflicts

7eb8551

add event trigger for personnel roles

a01f045

handle update if a person was removed from the team

fe46559

clean up activity log maps

28673dc

remove more from activity helpers

5343304

merging main and fixing merge conflicts

7750d0e

the record id should not be the project id

9b537a8

chiaberry commented Feb 2, 2023

View reviewed changes

chiaberry requested review from johnclary, frankhereford, mddilley, roseeichelmann and tillyw February 2, 2023 03:08

chiaberry commented Feb 2, 2023

View reviewed changes

johnclary added 2 commits February 2, 2023 10:18

tweak the updated and replaced event text

3fd5eca

fix invalid dom nesting by using typog span instead of p

a1cec5e

johnclary approved these changes Feb 2, 2023

View reviewed changes

mddilley approved these changes Feb 2, 2023

View reviewed changes

chiaberry merged commit d023f3e into main Feb 2, 2023

johnclary deleted the 10810-personnel-activity branch February 16, 2023 17:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update event triggers for moped personnel and personnel roles #964

Update event triggers for moped personnel and personnel roles #964

chiaberry commented Feb 1, 2023 •

edited

chiaberry Feb 2, 2023

johnclary Feb 2, 2023

chiaberry Feb 2, 2023

johnclary Feb 2, 2023

chiaberry Feb 2, 2023

johnclary left a comment

johnclary Feb 2, 2023

johnclary Feb 2, 2023

chiaberry Feb 2, 2023

johnclary Feb 2, 2023

mddilley left a comment •

edited

Update event triggers for moped personnel and personnel roles #964

Update event triggers for moped personnel and personnel roles #964

Conversation

chiaberry commented Feb 1, 2023 • edited

Associated issues

Testing

Ship list

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johnclary left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mddilley left a comment • edited

Choose a reason for hiding this comment

chiaberry commented Feb 1, 2023 •

edited

mddilley left a comment •

edited