This repository has been archived by the owner on Feb 28, 2024. It is now read-only.
Sd followup reactintl #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifsimicoded
commented
Mar 8, 2018
| @@ -21,4 +21,5 @@ npm-debug.log* | |||
| yarn-debug.log* | |||
| yarn-error.log* | |||
|
|
|||
| # sass to css | |||
There was a problem hiding this comment.
just curious if we want to clear out the defaults in the .gitignore that aren't relevent to our use case
ifsimicoded
commented
Mar 8, 2018
| @@ -27,6 +28,7 @@ ENV CMS_API=${CMS_API:-https://joplin.herokuapp.com/api/graphql/} | |||
| ARG CMS_MEDIA | |||
| ENV CMS_MEDIA=${CMS_MEDIA:-https://joplin.herokuapp.com/media/} | |||
|
|
|||
| COPY public /app/public | |||
There was a problem hiding this comment.
saw this was in Dockerfile but not in Dockerfile.build -- just I added it. Not sure it's necessary at this moment tho.
ifsimicoded
force-pushed
the
sd-followup-reactintl
branch
from
cdb0585
to
de14615
Compare
added 12 commits
March 12, 2018 16:39
ifsimicoded
force-pushed
the
sd-followup-reactintl
branch
from
e6a02d8
to
739d065
Compare
added 8 commits
March 12, 2018 17:50
added 2 commits
March 13, 2018 17:29
added 2 commits
March 13, 2018 17:34
5 tasks
ifsimicoded
force-pushed
the
sd-followup-reactintl
branch
from
26bd663
to
23520d3
Compare
mateoclarke
approved these changes
Mar 16, 2018
| @@ -21,4 +21,5 @@ npm-debug.log* | |||
| yarn-debug.log* | |||
| yarn-error.log* | |||
|
|
|||
| # sass to css | |||
| @@ -12,6 +12,7 @@ COPY yarn.lock /app/yarn.lock | |||
| COPY package.json /app/package.json | |||
| RUN yarn | |||
|
|
|||
| COPY intl.buildlangs.js /app/intl.buildlangs.js | |||
There was a problem hiding this comment.
we'll need to add this to the Docker.storybooks too huh.
There was a problem hiding this comment.
nah, the build langs is only to generate the base english json -- so it's only needed in a dev environment
| To re-generate default.json to update the static content to be translated, the following command can be run: | ||
|
|
||
| ``` | ||
| docker exec --interactive --tty janis yarn run build-langs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Janis static content language translation