-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug reentry of space plane #321
Conversation
A space lift only takes 3 turns with the current implementation: civctp2/ctp2_data/default/gamedata/Units.txt Line 3530 in 11b9a02
civctp2/ctp2_code/gs/gameobj/ArmyData.cpp Line 1735 in 11b9a02
which is more appropriate than 4 turns as stated in the GL, so c1e0e1e changes the GL files accordingly. However for awk to work properly for all language files, also TXT files need to be normalized to use LF as EOL (855e070 and 83be17a), which needs to be tested if that has any negative effect on windows. @MartinGuehmann could you do that? |
I wonder if we should reduce the move points of a space plane. Currently it can move so far in one turn that it often makes little sense to use a space launch unless one wants to pass over enemy terrain. For non-gigantic maps the use of a space launch reduces further. Considering that it seem comparable to the NASA Space Shuttle, its ability to fly from one city to another on its own is not very realistic any way and in case of saying that it gets transported by a carrier, it would be realistic to say that this can be done only with very few move points per turn, while possibly keeping or adjusting the fuel points. |
…moval is never used
This reverts commit 80fb496.
Halfed move points to better fit the concept also described in the GL: civctp2/ctp2_data/english/gamedata/Great_Library.txt Lines 9030 to 9032 in 3294daa
|
Tested this for some time now and seems to work as expected now. @MartinGuehmann ready for merge? |
Why do you hard encode the value and don't use {UnitDB(UnitRecord[0]).SpaceLaunch}? |
see https://github.com/civctp2/civctp2/blob/11b9a024f4e0b5ace7011f6e53a49f5f7bb83651/ctp2_data/default/gamedata/Units.txt#L3530 https://github.com/civctp2/civctp2/blob/11b9a024f4e0b5ace7011f6e53a49f5f7bb83651/ctp2_code/gs/gameobj/ArmyData.cpp#L1735 find -name Great_Library.txt -exec awk -i inplace '/UNIT_SPACE_PLANE_GAMEPLAY/ {found=1}; /4/ && found { gsub(4, "{UnitDB(UnitRecord[0]).SpaceLaunch}", $0); found=0} 1' {} \;
…o space launch and to be less a replacement for cargo heli
Because it was hard encoded before;-) but I like the idea and changed the commit accordingly. |
Works as expected. |
Then we can merge. |
PR to solve #229.