Merge pull request #26132 from eileenmcnaughton/report_notice

Contribution reports, specify type for is pledge payment
civicrm · May 1, 2023 · 215653d · 215653d
2 parents f0b6536 + e06a84c
commit 215653d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/CRM/Report/Form.php b/CRM/Report/Form.php
@@ -750,6 +750,8 @@ public function preProcessCommon() {
     }
 
     $this->assign('criteriaForm', FALSE);
+    // Will be overwritten in postProcess if TRUE.
+    $this->assign('printOnly', FALSE);
     // Display Report Criteria section if user has access Report Criteria OR administer Reports AND report instance is not reserved
     if (CRM_Core_Permission::check('administer Reports') ||
       CRM_Core_Permission::check('access Report Criteria')

diff --git a/CRM/Report/Form/Contribute/Detail.php b/CRM/Report/Form/Contribute/Detail.php
@@ -260,6 +260,7 @@ public function __construct() {
           'filters' => [
             'contribution_id' => [
               'title' => ts('Contribution is a pledge payment'),
+              'type' => CRM_Utils_Type::T_BOOLEAN,
             ],
           ],
         ],

diff --git a/CRM/Report/Form/Contribute/Summary.php b/CRM/Report/Form/Contribute/Summary.php
@@ -289,6 +289,7 @@ public function __construct() {
         'filters' => [
           'contribution_id' => [
             'title' => ts('Contribution is a pledge payment'),
+            'type' => CRM_Utils_Type::T_BOOLEAN,
           ],
         ],
       ],

diff --git a/templates/CRM/Report/Form/Layout/Table.tpl b/templates/CRM/Report/Form/Layout/Table.tpl
@@ -98,7 +98,7 @@
                     {assign var=fieldHover value=$field|cat:"_hover"}
                     {assign var=fieldClass value=$field|cat:"_class"}
                     <td class="crm-report-{$field}{if $header.type eq 1024 OR $header.type eq 1 OR $header.type eq 512} report-contents-right{elseif $row.$field eq 'Subtotal'} report-label{/if}">
-                        {if !empty($row.$fieldLink)}
+                        {if array_key_exists($fieldLink, $row) && $row.$fieldLink}
                             <a title="{$row.$fieldHover|escape}" href="{$row.$fieldLink}"  {if array_key_exists($fieldClass, $row)} class="{$row.$fieldClass}"{/if}>
                         {/if}
 
@@ -130,7 +130,7 @@
                             {$row.$field}
                         {/if}
 
-                        {if !empty($row.$fieldLink)}</a>{/if}
+                        {if array_key_exists($fieldLink, $row) && $row.$fieldLink}</a>{/if}
                     </td>
                 {/foreach}
             </tr>