CRM-16276 Daily jobs run by cron slip forward each day, until eventua…

…lly missed
civicrm · May 12, 2015 · d0be153 · d0be153
1 parent b2e40a0
commit d0be153
Showing 1 changed file with 9 additions and 13 deletions.
diff --git a/CRM/Core/ScheduledJob.php b/CRM/Core/ScheduledJob.php
@@ -101,23 +101,19 @@ public function needsRunning() {
         return TRUE;
 
       case 'Hourly':
-        $now = CRM_Utils_Date::currentDBDate();
-        $hourAgo = strtotime('-1 hour', strtotime($now));
-        $lastRun = strtotime($this->last_run);
-        if ($lastRun < $hourAgo) {
-          return TRUE;
-        }
+        $format = 'YmdH';
+        break;
 
       case 'Daily':
-        $now = CRM_Utils_Date::currentDBDate();
-        $dayAgo = strtotime('-1 day', strtotime($now));
-        $lastRun = strtotime($this->last_run);
-        if ($lastRun < $dayAgo) {
-          return TRUE;
-        }
+        $format = 'Ymd';
+        break;
     }
 
-    return FALSE;
+    $now = CRM_Utils_Date::currentDBDate();
+    $lastTime = date($format, strtotime($this->last_run));
+    $thisTime = date($format, strtotime($now));
+
+    return ($lastTime <> $thisTime);
   }
 
   public function __destruct() {