CRM-20507 - Allow only public custom groups to display on participant receipts

[jitendrapurohit]

• CRM-20507: Prevent disclosure of is_public=0 Custom Groups in email templates

[lcdservices]

Tested and confirmed. Prior to this patch participant custom data marked not public was still included in the email receipt when generating a backoffice registration. With this patch it is excluded.

[jitendrapurohit]

Thanks @lcdservices

@eileenmcnaughton @monishdeb Can we merge this since it has been tested by Brian.

[eileenmcnaughton]

Yes, I'm happy to take Brian's review on this. I have a feeling this patch will make someone very happy - I can't recall who. Can you remember who was hoping for this fix @seamuslee001 ?

[KarinG]

Hi - just a note that when using APIs (e.g. a webform civicrm Event registration) - this solution of course does not work. All Contribution custom fields regardless of whether they are marked as "Is this Custom Data Set public?" => no; show up on the Emailed Receipt [Events - Registration Confirmation and Receipt (on-line) in this case].

[eileenmcnaughton]

Yes - this is the wrong place for the fix - it's in the form layer not the IPN section. I'd like to think we've cleaned stuff enough since this was merged we would not let it go in the form layer today