Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21043 - Dupe check of on behalf organisation not working #10830

Merged
merged 1 commit into from Aug 23, 2017

Conversation

jitendrapurohit
Copy link
Contributor

@jitendrapurohit jitendrapurohit commented Aug 8, 2017

Overview

Fixes check for dupe for onbehalf organization.

Before

When submitting live contribution with onbehalf - duplicate name doesn't update the organization contact.

After

works fine and correctly updates existing org contact if any.

Technical Details

getFirstDuplicateContact() returns only one dupe contact, but seems we need a count of all dupes here in order to set onbehalf_dupe_alert in $params.

Comments

Added unit test.


@eileenmcnaughton
Copy link
Contributor

This code change makes sense & the test = yay

@eileenmcnaughton eileenmcnaughton merged commit 58e6471 into civicrm:master Aug 23, 2017
@jitendrapurohit
Copy link
Contributor Author

Thanks @eileenmcnaughton

@jitendrapurohit jitendrapurohit deleted the CRM-21043 branch August 23, 2017 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants