CRM-20927 Migrate Upgrade code from mysql.tpl to PHP for saftey and s… #10858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totten
reviewed
Aug 14, 2017
| * @param string $rev | ||
| */ | ||
| public function upgrade_4_7_25($rev) { | ||
| $this->addTask('CRM-20927 - Add Generic Column for other data', 'addColumn', |
There was a problem hiding this comment.
@seamuslee001 Thanks, this is a good idea/safer code-convention.
Nitpick: from the perspective of an admin watching the upgrade UI, this would display a message "CRM-20927 - Add Generic Column for other data", which seems meaningless at a glance. The capitalization also looks pretty arbitrary.
Maybe something like "CRM-20927 - Add column to 'civicrm_menu' for additional metadata"?
There was a problem hiding this comment.
Thanks tim, makes more sense agreed , have updated message now
totten
force-pushed
the
move_module_data_php
branch
from
178c30a
to
07683c3
Compare
|
Retested on my local and confirmed that the new column is still created. Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tability
Overview
This just migrates the adding of the module_data
Before
At present the Column is added in the SQL function which can have a hard failure if the column already exists in the databsae
After
Column is now added through php using the addColumn helper function which checks to see if the column is present already
@totten does this makes sense to you give you wrote the original upgrade script