CRM-20226 [NFC] add comment to warn coders about performance impact #11011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eileenmcnaughton does that generate the smart group count? |
|
@seamuslee001 yes - some time back there was discussion about generating the count on-demand rather than always, for performance reasons. The change I'm grumpy about brought back the 'always' partially - ie. it only applies to the first 25 groups (no matter how many are displayed) |
|
jenkins re test this please |
|
Makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a code comment notifying devs about the risk of improving group resolution.
@monishdeb the line commented is a change you made. I've decided the performance issue is manageable for us after a group tidy up but can you read & merge for future.