Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21224 reinstate use of limit on dedupe searches #11123

Merged
merged 1 commit into from
Oct 14, 2017

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 12, 2017

Overview

For perfomance reasons a site might want to put limit=5000 in the url of dedupe find. This means only the first 5000 contacts will be checked for dupes & can prevent runaway queries. It can be used in conjunction with other critieria. It limits the number of contacts searched, not the number of matches found. A recent bug fix tidied up some function calls but did not include passing this parameter on appropriately

Before

limit in url is ignored - e.g civicrm/contact/dedupefind?reset=1&action=update&rgid=4&gid=&limit=50000&context=conflicts

After

Code loves & cares for limit paramter

Technical Details

#11030 got too complex - taken from there.


@MegaphoneJon
Copy link
Contributor

I'd like to label this feature as "Needs Documentation" :)

@eileenmcnaughton
Copy link
Contributor Author

Yep it does - although I think the reason it's mostly hidden at the moment was because we have been getting back to extending it & making it clearer

@colemanw colemanw merged commit 21a95d8 into civicrm:master Oct 14, 2017
@eileenmcnaughton eileenmcnaughton deleted the dedupe_loosing_limit branch October 15, 2017 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants