CRM-21476 Rename clicks to unique clicks in mailing summary report #11319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
A test failure for changing a label! I think not. Jenkins, retest this please. |
|
I think the only review required for this is whether the change is an improvement - since it only adjusts the label text. I'm taking @mattwire thumb's up as confirmation of that. |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-21476 Rename clicks to unique clicks in mailing summary report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Rename 'Clicks' to 'Unique Clicks' in mailing summary report. Because it's showing 'the number of people who have clicked on links in the mailing' - not the total number of clicks.
The logic is correct. Just tidying up the labeling.
Before
Column in mailing summary is called 'Clicks'.
After
Column in mailing summary is called 'Unique clicks'.
Technical Details
No technical changes. String changed.