Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#174) Add various utilities to support PSR-16 #12376

Merged
merged 6 commits into from Jun 30, 2018

Conversation

totten
Copy link
Member

@totten totten commented Jun 29, 2018

Overview

This is an auxiliary PR in support of #12360. It reproduces the general utilities that help with a PSR-16 compliant cache provider.

After

  • There are concrete-classes to represent cache exceptions.
  • There is a base-class for end-to-end testing of caches.
  • NaiveMultipleTrait handles bad inputs more correctly.
  • CRM_Utils_Date has functions for calculating TTL and/or expiration based on NULL|int|DateInterval.

@civibot
Copy link

civibot bot commented Jun 29, 2018

(Standard links)

@eileenmcnaughton
Copy link
Contributor

I'm pretty comfortable the failed tests all relate to time-specific recurrent issues.

Merging this as it is helper functions / additional code. I agree in principle with the rationale for adding them

@eileenmcnaughton eileenmcnaughton merged commit eabff8a into civicrm:master Jun 30, 2018
@totten totten deleted the master-psr16-util branch June 30, 2018 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants