dev/cloud-native/issues#17: Moving the cache for CRM_Extension_Browser out of the filesystem and use a SqlGroup instead.
#12624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
(Standard links)
|
|
add to whitelist |
|
@tiotsop01 this has triggered a bunch of style warnings - I think the links the bot pasted help if you aren't sure about the style issues |
totten
reviewed
Aug 16, 2018
| } | ||
| $this->browser = new CRM_Extension_Browser($this->getRepositoryUrl(), '', $cacheDir); | ||
| $this->browser = new CRM_Extension_Browser($this->getRepositoryUrl(), '', $cache); |
There was a problem hiding this comment.
This doesn't match the revised signature of CRM_Extension_Browser::__construct() -- ie
- It now expects a
CRM_Utils_Cache_Interface $cacheandCRM_Utils_HttpClient $clientas the first two args. - It no longer expects a
string $cacheDiras the last two args.
|
This is a really appealing change- but my sense it that @tiotsop01 was a GSOC student & is not likely to work on progressing this now & it does need changes so I'm going to close & track via gitlab - it can be reopened if someone does want to pick it up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
The current code in CRM_Extension_Browser is coded specifically for an adhoc, file-based caching logic
After
Change the backing/storage from a JSON file to the civicrm_cache table (at least, for the typical usage).
Comments
see comments in gitlab