Export code cleanup - remove silly function

[eileenmcnaughton]

Overview

Export code cleanup

Before

Label built wrongly & then wrangled. No test

After

Label built correctly. Test

Technical Details

@mattwire this is a pretty small next step but it seems I already had it ready & wating :-) Oh I removed some more special handling on field names that didn't seem to warrant it

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

@eileenmcnaughton Test failure because testExportRelationships() is expecting field names instead of labels on the relationship-xxx fields. That change probably makes sense but the test will need modifying as part of this PR. Apart from that issue, I tested this with a simple export selecting "Employee Of-display name" and a couple of standard fields and it exported fine as far as I could tell.

[eileenmcnaughton]

@mattwire - thanks - I've pushed a fix on the test & will give this merge-on-pass based on your review