dev/core#561 Remove jcalendar from the Event Aggregate Custom Search #13198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
force-pushed
the
event_search_561
branch
2 times, most recently
from
249518b
to
5c81c98
Compare
|
Jenkins re test this please |
|
So this changes the date fields so that you can enter a time as well - is that intentional? As you could not do so before. Apart from that change, it's working fine and ok to merge, just need @seamuslee001 to confirm if the change to allow time entry is intentional. |
seamuslee001
force-pushed
the
event_search_561
branch
from
5c81c98
to
84fb17e
Compare
|
wasn't intentional @mattwire so have switched it back now can you re-test please |
|
Ok, retested. Ok to merge. |
|
Adding merge on pass based on @mattwire 's review |
|
Merging as per the tag and Matt's review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This removes the usage of jcalendar from the event aggregate custom search
Before
deprecated jcalendar used for the search
After
date picker used in stead
ping @eileenmcnaughton @mattwire