dev/joomla#3 CRM-21780 Fix Mailings Recipients box incompatabilites … #13294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with certain instances of Joomla
|
(Standard links)
|
|
I have this running on a production site and it fixes the issue. Selected mailing groups are now visible and there are no console errors. |
|
Reviewed by @lcdservices so ok to merge @eileenmcnaughton @seamuslee001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…with certain instances of Joomla
Overview
This fixes a difficult issue to reproduce on joomla which impacts Recipients box on a new mailing. This changes it to be a more standard for loop in javascript.
Before
Box breaks in certain circumstances in Joomla
After
Should work normally in Joomla from now on
ping @lcdservices @eileenmcnaughton @mattwire