Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#620 - Unable to show custom fields on Repeat Contributions Report #13350

Merged
merged 2 commits into from Dec 27, 2018

Conversation

francescbassas
Copy link
Contributor

https://lab.civicrm.org/dev/core/issues/620

Overview

When you select a custom field column on a Repeat Contributions Report it results with a "Do not select field with Group by Contact." error message.

@civibot
Copy link

civibot bot commented Dec 24, 2018

(Standard links)

@civibot civibot bot added the master label Dec 24, 2018
@francescbassas
Copy link
Contributor Author

Jenkins re test this please

@jitendrapurohit
Copy link
Contributor

I was able to replicate the issue on master version and confirm that this PR fixes the error mentioned in the description. Though - the value displayed after this PR seems to be a name instead of label. See screenshot which prints M and D for marital status field and Edu for Most imp issue.

image

@francescbassas Can you make a quick change to display the label values for the custom fields?

Thanks.

@francescbassas
Copy link
Contributor Author

I've been looking at how to put the name instead the label and I have not got it. During my research I have noticed that almost Donor Report (Summary) has the same behaviour.

@jitendrapurohit I think it would be better to treat label behavior as a different issue.

@yashodha
Copy link
Contributor

@francescbassas

I agree we can have a separate PR for fixing label instead of name behavior.

@yashodha yashodha merged commit f01f6ac into civicrm:master Dec 27, 2018
@francescbassas francescbassas deleted the patch-16 branch December 27, 2018 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants