Membership form address fields for payment processors

[mattwire]

Overview

Actually use the values processed by the function processBillingAddress..

Before

If county or country fields are not set then the entire list of counties/countries are passed as an array in the PHP form values.

After

We use the standard functions for parsing/validating address parameters.

Technical Details

$this->processBillingAddress() acts on $this->_params but we've already assigned it to $formValues so ignore the result...

Comments

testSubmitPayLaterWithBilling covers this

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@mattwire this makes sense to me - by getting $formValues from $this->_params a few lines later the standardised address wrangling is already done and a form-specific-handling is not needed. I stepped through in the test & it looks good. Merging