dev/core#1010 pledge_acknowledge template - capitalization and greeting #14465
Conversation
Pledge Acknowledgements have incorrect capitalization in greetings, and greetings do not use email_greeting.
|
Can one of the admins verify this patch? |
|
(Standard links)
|
|
jenkins, ok to test |
|
@philmb well done - I'm gonna add a couple of inline comments |
| @@ -1,4 +1,4 @@ | |||
| {ts 1=$contact.display_name}Dear %1{/ts}, | |||
| {assign var="greeting" value="{contact.email_greeting}"}{if $greeting}<p>{$greeting},</p>{/if} | |||
|
|
|||
| {ts}Thank you for your generous pledge. Please print this acknowledgment for your records.{/ts} | |||
There was a problem hiding this comment.
Can we remove this " Please print this acknowledgment for your records." too while we are at it - there is a gitlab somewhere but summary is it's not environmental
| @@ -112,6 +112,15 @@ protected function getTemplateUpdates() { | |||
| ['name' => 'payment_or_refund_notification', 'type' => 'html'], | |||
| ], | |||
| ], | |||
| [ | |||
| 'version' => '5.14', | |||
There was a problem hiding this comment.
version is a little tricky just because today is the day it changes - if changed right now it should be 5.15 - but later today the 5.15 rc will be cut & the master branch will be 5.16
|
Actually I'm going to merge this & do those changes as a follow up - I'm concerned that 'version' is a moving target today so I want to wrap this up before it moves! |
|
@philmb Oh one more thing - getting adding to Contributors is DIY - wanna do a PR on Contributors.yml? |
Overview
Pledge Acknowledgements have incorrect capitalization in greetings, and greetings do not use email_greeting.
Before
dear DisplayName
thank you....
After
Uses Email_Greeting and fixes capitalization
Technical Details
https://lab.civicrm.org/dev/core/issues/1010
Comments
Not sure what version to use in MessageTemplates.php.