Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some test leakage #14731

Merged
merged 1 commit into from Jul 4, 2019
Merged

Fix some test leakage #14731

merged 1 commit into from Jul 4, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 4, 2019

Overview

Fixes a cause or false fails in unit tests

Before

Doing unit tests which interact with soft credit searching can cause other tests to fail

After

Tests stop leaking

Technical Details

I encountered this as part of the long saga of #14514 - basically there were 3 issues

  1. a static class variable that was leaking between test runs - this is just being handled in test tearDown for now as a larger cleanup is needed to properly address
  2. the decision as to whether to create a temp table was an in function static variable - which persisted between runs
  3. the table itself persisted between runs

Comments

@seamuslee001 FYI with this the soft credit test finally passes!

@civibot
Copy link

civibot bot commented Jul 4, 2019

(Standard links)

@seamuslee001
Copy link
Contributor

looks good to me adding MOP

@seamuslee001
Copy link
Contributor

Jenkins re test this please

1 similar comment
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001 seamuslee001 merged commit 01fee78 into civicrm:master Jul 4, 2019
@seamuslee001 seamuslee001 deleted the leaky branch July 4, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants