[Import] [Cleanup] remove unused parameters #14981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like some copy & past put these vars here as they are never set & not exposed for contribution imporrt
|
(Standard links)
|
|
test this please |
1 similar comment
|
test this please |
This was referenced Aug 11, 2019
Closed
|
change makes sense merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code cleanup -remove some variables that only confuse
Before
After
Removed
As we can see the fields are not actually available in the UI for contribution import so no actual change
Technical Details
Looks like some copy & past put these vars here as they are never set & not exposed for
contribution import
Comments