Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ref] Import use process for relationship defaults, add test #15215

Merged
merged 4 commits into from Sep 4, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Further code cleanup to use the processor class. In the process I discovered contact subtype is not yet set on the processor class - merging this in the same civi version as related cleanups would be safer.

Adds unit tests to cover

Before

Hard to read

After

Easier to read

Technical Details

Part of cleanup & adding unit tests

Comments

@colemanw @seamuslee001 I think we should merge this before 5.18rc is cut. Risk of edge case bug from not having set contactSubType is low but avoidable

@civibot civibot bot added the master label Sep 4, 2019
@civibot
Copy link

civibot bot commented Sep 4, 2019

(Standard links)

@seamuslee001
Copy link
Contributor

seems to make sense to me adding merge on pass

@eileenmcnaughton
Copy link
Contributor Author

uunrelated fail

@eileenmcnaughton eileenmcnaughton merged commit 08a7018 into civicrm:master Sep 4, 2019
@eileenmcnaughton eileenmcnaughton deleted the import_next branch September 4, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants