[REF] Move calculation of js for import fields WITH relationship keys to processor. #15218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@eileenmcnaughton test fails related |
…ocessor. As should be obvious we can collapse a lot more out with the next commit now....
eileenmcnaughton
force-pushed
the
import_again
branch
from
34cca87
to
a9f13f0
Compare
|
@seamuslee001 ah yes - that does rather prove the test cover - I had a missing ! |
|
Test failures unrelated merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Further import tidy up - part of a serious of small changes leading to big cleaning
Before
Less readable
After
More readable
Technical Details
As should be obvious we can collapse a lot more out with the next commit now....
Comments