dev/core#1272 - PHP 7.3 warning message on import contribution

[jitendrapurohit]

Overview

Fix warning on import contribution

Before

Get the below warning on Import Contribution screen after selecting the csv and moving on the "Match Fields" page.

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in require_once() (line 227 of /Users/jitendra/src/civicrm/CRM/Core/ClassLoader.php).

After

warning message is not shown.

Technical Details

https://www.php.net/manual/en/migration73.incompatible.php#migration73.incompatible.core.continue-targeting-switch

Comments

Gitlab - https://lab.civicrm.org/dev/core/issues/1272

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

• General standards
  • [r-explain] PASS
  • [r-user] PASS
  • [r-doc] PASS
  • [r-run] PASS
    • I was able to reproduce the warning (PHP 7.3.9) and the patch fixes it.
• Developer standards
  • [r-tech] PASS
  • [r-code] PASS
    • The original continue is equivalent to break in this context. I also checked there's nothing after the switch inside the loop that might question the original author's intent (i.e. did they mean to skip something in the outer for loop - I can't see why they would).
  • [r-maint] N/A
  • [r-test] PASS