Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Remove call to depreacated getValue call in Mailing Preferences… #15368

Conversation

seamuslee001
Copy link
Contributor

… settings form

Overview

Removes call to deprecated function

Before

Deprecated function used

After

Non deprecated code used

ping @eileenmcnaughton @mattwire

@civibot
Copy link

civibot bot commented Oct 1, 2019

(Standard links)

@civibot civibot bot added the master label Oct 1, 2019
@colemanw colemanw added the merge ready PR will be merged after a few days if there are no objections label Oct 1, 2019
@colemanw
Copy link
Member

colemanw commented Oct 1, 2019

Looks good to me. Anyone else have feedback?

@eileenmcnaughton
Copy link
Contributor

Tested & it works fine - I thought we might have had a better method but as this is not attached to an entity I can't spot one

@eileenmcnaughton eileenmcnaughton merged commit 289f2f1 into civicrm:master Oct 2, 2019
@eileenmcnaughton eileenmcnaughton deleted the deprecated_getvalue_mailing_prefernces branch October 2, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
3 participants