Permit modified_id as a parameter for membership create api #16166
Conversation
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
mod_member
branch
from
a59bfb8
to
29a67df
Compare
|
test this please |
Adding a membership create api parameter makes this accessible via the api and also allows us to deprecate & remove the array. Note this PR does nothing at the api level to make it available - it just takes advantage of apiv3 passing params through to the BAO. The support is added in the BAO. However, I think we should add formal apiv4 support for modified_id as a parameter for Membership.create - only issue is that of course it's not a 'real' param so we need to discuss / understand how that needs to look. In general I think there are a few BAO that store modified_id
eileenmcnaughton
force-pushed
the
mod_member
branch
from
29a67df
to
6dbee28
Compare
| if ($session->get('userID')) { | ||
| $membershipLog['modified_id'] = $session->get('userID'); | ||
| elseif (CRM_Core_Session::singleton()->get('userID')) { | ||
| $membershipLog['modified_id'] = CRM_Core_Session::singleton()->get('userID'); | ||
| } | ||
| elseif (!empty($ids['userId'])) { |
There was a problem hiding this comment.
@eileenmcnaughton just wondering if we could do something like this earlier up
if (empty($params['modified_id'] && !empty($ids['userId'])) {
$params['modified_id'] = $ids['userId'];
}There was a problem hiding this comment.
@seamuslee001 so next step is to stop passing $ids into add at all & pass modified_id in from create
There was a problem hiding this comment.
@eileenmcnaughton We should replace get('userID') with getLoggedInContactID()
There was a problem hiding this comment.
@mattwire yes - there is a bunch of follow on tidy up we should do - goal one is just to get $ids out of the params for the add function
There was a problem hiding this comment.
ie once there is an alternative we can eliminate $ids['userID']
|
agree with @mattwire about changes but i think this is a step forward and has a unit test. merging |
Overview
Adds modified_id as a parameter to CRM_Member_BAO_Membership::create (this is available via apiv3 & can be available for apiv4 too with some discussion about how best to do so).
Before
Setting modified_id only possible by calling the BAO create (or add) function & passing in the deprecated $ids array
After
modified_id is a key in $params
Technical Details
The key goal here is really about deprecating the $ids array so we can remove it as a parameter from the add function and work to remove it from create. I will follow on with that once this is merged
There is quite a bit of inconsistency with member.create & for apiv3 there is stuff in the api layer that should be in the BAO. There is also some stuff that should go.
Note this PR does nothing at the api level to make it available - it just takes advantage of apiv3 passing params through to the BAO.
I think we should add formal apiv4 support for modified_id
as a parameter for Membership.create - only issue is that of course it's not a 'real' param so we need to discuss /
understand how that needs to look. In general I think there are a few BAO that store modified_id
Comments