Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jQuery validation version to v1.19.1 #16625

Merged
merged 1 commit into from Mar 5, 2020

Conversation

seamuslee001
Copy link
Contributor

Overview

Upgrades JQuery validate version to 1.19.1

Before

older version of jQuery validate used

After

latest version of JQuery validate used

ping @mattwire @colemanw @mlutfy

@civibot
Copy link

civibot bot commented Feb 25, 2020

(Standard links)

@civibot civibot bot added the master label Feb 25, 2020
@mattwire
Copy link
Contributor

test this please

@mattwire
Copy link
Contributor

Thanks @seamuslee001 I'm happy to merge this but I also proposed it so we should get a couple of "I've tested this and it's fine" (it should not make any real difference at this point but nothing should break).
jquery validation is available on contribution/event registration forms but won't normally run unless triggered. You can do that by running CRM.$('#Main').valid() on a contribution page for example and it should display errors next to any invalid fields (basically just required fields that don't have values).

@yashodha
Copy link
Contributor

test this please

@seamuslee001
Copy link
Contributor Author

Jenkins re test this please

@yashodha
Copy link
Contributor

yashodha commented Mar 4, 2020

test failure looks unrelated

@yashodha
Copy link
Contributor

yashodha commented Mar 4, 2020

test this please

1 similar comment
@colemanw
Copy link
Member

colemanw commented Mar 4, 2020

test this please

@mattwire mattwire merged commit 5740981 into civicrm:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants