dev/core#1646 Merge Case Modal not showing relevant cases

[bjendres]

Overview

See https://lab.civicrm.org/dev/core/issues/1646

Before

Case type dropdown shows no more than 25 cases

After

Case type dropdown shows all cases

Technical Details

The API has a default limit of 25

Comments

Might be an issue if somebody has too many cases, which can happen.

@demeritcowboy writes:

As noted in the comments in the description, the dropdown might be unwieldy if they have a ton of cases for the same client. Note the dropdown includes closed cases too, since merging to a closed case is perfectly normal, so the number of entries in the list will always be increasing.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Thanks @bjendres.

• General standards
  • [r-explain] Suggestion
    • Just to clarify the description, it's not how many case types, it's about how many cases for the same client they have when they go to merge a case.
  • [r-user] PASS with comment
    • As noted in the comments in the description, the dropdown might be unwieldy if they have a ton of cases for the same client. Note the dropdown includes closed cases too, since merging to a closed case is perfectly normal, so the number of entries in the list will always be increasing.
  • [r-doc] PASS
  • [r-run] PASS Works
• Developer standards
  • [r-tech] PASS
    • As discussed in lab ticket, this is the simplest approach. It doesn't require touching much code and is pretty self-contained.
  • [r-code] PASS
  • [r-maint] Undecided
  • [r-test] PASS Pending results of test run

[bjendres]

@demeritcowboy thanks, have updated the description.

[eileenmcnaughton]

Merging based on @demeritcowboy's review - I'm not concerned about the [r-maint] Undecided

I do wonder if we don't have a better select2 / entity ref way of displaying but absent a bigger change this makes sense