Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] move buildQuickForm function to the trait #16948

Merged
merged 1 commit into from Apr 2, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 1, 2020

Overview

Minor code tidy up on send-email tasks - no impact on functionality

Before

Duplication of buildQuickForm

After

Function shared via trait

Technical Details

Note that Contact had an extra assign. It seems likely the extra assign is not required but it
would not be a bad thing on the others

Comments

Note that Contact had an extra assign. It seems likely the  extra  assign  is not required  but it
would not be a bad thing on the others
@civibot
Copy link

civibot bot commented Apr 1, 2020

(Standard links)

@civibot civibot bot added the master label Apr 1, 2020
@eileenmcnaughton
Copy link
Contributor Author

test this please

@totten totten merged commit 1c639c8 into civicrm:master Apr 2, 2020
@eileenmcnaughton eileenmcnaughton deleted the email4 branch April 2, 2020 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants