dev/drupal#127 - CRM_Core_Session::setStatus() gets ignored sometimes

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/drupal/-/issues/127

This part isn't specific to drupal.

It looks like there are two paths to get a status message popup. One follows a javascript-only path, the other goes through templates/CRM/common/info.tpl. For the second one, if you only set a title and leave the message blank when calling CRM_Core_Session::setStatus(), then it gets ignored.

There's a couple places where this happens:

• On the Create User Record action you can choose when viewing a contact
  • This is what the drupal ticket was originally about, but there's also a second bug in case of error so this alone doesn't fix the if-error part, but fixes the success message. On drupal 7 though you wouldn't think about it because you see the CMS's message anyway, but it's more obvious on drupal 8 (well, if the absence of something could be considered "obvious").
• After doing batch update for contact records.
• After deleting a campaign survey.

Probably the easiest way to reproduce is:

1. Do a contact search.
2. Select a couple and from the actions dropdown choose Update Multiple.
3. Choose a profile. New Individual is simple.
4. Make your changes and click Update.
5. Did it succeed? It's a mystery.

Before

No popup status message.

After

Popup status message as intended.

Technical Details

All the code along the way seems to support having a title but no message except the last stage when it runs thru the template, where it only does anything if there's a message component.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw looks sane to me - thoughts?

[eileenmcnaughton]

I'm gonna merge this - seems very sane.