dev/core#1913 Allow for schemas to be added by extensions if they are…

[seamuslee001]

… in the format of Model

Overview

This is an alternate PR to #17971 which aims to achieve the same effect without the new hook

Before

Adding in an entity GrandModel for UF ProfileSchema doesn't work without a core override

After

Does work without a core override as long as there are availabe fields added

ping @colemanw @eileenmcnaughton @monishdeb

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 are those tests still valid?

[seamuslee001]

@eileenmcnaughton Yes one of the test is showing that with Grant Fields added via the UF Fields hook then sepecifiying GrantModel works without any extra code which it doesn't do right now, the 2nd test is showing that if you pass in a model entity that has no fields e.g. in that case PledgeModel then it should still correctly error (i.e. the expectedException is thrown)

[eileenmcnaughton]

OK - I'm happy with that then - it is using an existing hook, code changes seem sensible & based on reviewer input and it's tested

[eileenmcnaughton]

Actually @seamuslee001 one more thing - can you add some explanatory doc blocks to the test functions?

[seamuslee001]

Hopefully should be fine now @eileenmcnaughton

[eileenmcnaughton]

unrelated fail

[mattwire]

@seamuslee001 This needs some kind of documentation - if I stumbled upon that bit of code that's added here I would have no idea what is a "Model" or what it is doing?

[eileenmcnaughton]

Hmm - I'm happy for it to work - but in no hurry to encourage anyone else to use it by documenting it

[mattwire]

@eileenmcnaughton At the very least we should have a code comment otherwise it just makes it harder for any poor dev refactoring this code in the future.