Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1934 fix regression on merging contacts with settings using contact_id #18126

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

This is an interim fix to a reported regression. I'll look at more carefully in master when time permits

Before

Attempting to dedupe 2 contacts with settings with contact IDs will cause a fatal. My understanding is this would only be the case if an extension implemented it

After

Dedupe works

Technical Details

Comments

@civibot
Copy link

civibot bot commented Aug 11, 2020

(Standard links)

…contact_id

This is an interim fix to a reported regression. I'll look at more carefully in master when time permits
@seamuslee001
Copy link
Contributor

@eileenmcnaughton I think there is an activity related setting that is a per contact thing but yes this seems correct to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants