dev/financial#86 Make 'Record Payment' & 'Record Refund' visible regardless of whether the balance 'requires' one

[eileenmcnaughton]

Overview

This was agreed about a year ago - might as well do it

Before

No way to record an overpayment or unintended refund in the UI

After

Note the Contribution status is not altered if a contribution is overpaid - adding a payment <> changing the amount that we expected to be paid, it just means you can enter it. I am not sure if adding a refund (e.g bounced check) changes to 'Partially refunded' or even if it should - but those things are not specific to this change but rather to how Payment.create action works

Technical Details

I've kept this to the one place for now - if it gets complicated I'lll punt it again but it looked easy when I saw the gitlab (looking for something else)

Comments

Let's merge this based on an emoji poll - I'm sure there are other things we could do but I'm not that motivated so I'd like to either merge or close this (& if closed return to gitlab). I don't mind looking at follow up changes on how Payment.create should act (there may already be existing gitlabs)

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I included this in the dev digest

[eileenmcnaughton]

I pasted in dev-financial to try to get some more emoji pollsters as only 2 so far

[seamuslee001]

This has been posted in the dev-digest, has had post in dev-financial seems to make sense to me No one seems to be objecting at this stage merging