Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate language around social media sharing #18743

Merged
merged 3 commits into from Oct 12, 2020

Conversation

vingle
Copy link
Contributor

@vingle vingle commented Oct 12, 2020

Overview

The option to turn on and off the social media sharing footer suggests that an event, contribution or petition page cannot be shared without turning this setting on ("allow sharing through social media"). It also does not indiciate that turning this setting on will load buttons and scripts from specific social media networks. More details in this issue: https://lab.civicrm.org/dev/user-interface/-/issues/21.

Before

Checkbox label reads "Allow sharing through social media?:"
image

After

Checkbox label reads "Add footer region with Twitter, Facebook and LinkedIn share buttons and scripts?".
image

Comments

Translations of this string will not be changed, this only works for English.

Change in language to be more accurate, in relation to this issue: https://lab.civicrm.org/dev/user-interface/-/issues/21#note_48976.
Change in language to be more accurate, in relation to this issue: https://lab.civicrm.org/dev/user-interface/-/issues/21#note_48976.
Change in language to be more accurate, in relation to this issue: https://lab.civicrm.org/dev/user-interface/-/issues/21#note_48976.
@civibot
Copy link

civibot bot commented Oct 12, 2020

(Standard links)

@civibot civibot bot added the master label Oct 12, 2020
@vingle vingle closed this Oct 12, 2020
@vingle vingle reopened this Oct 12, 2020
@eileenmcnaughton eileenmcnaughton merged commit 43edd01 into civicrm:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants