dev/core#2159 Handle exceptions in Mail:send class

[eileenmcnaughton]

Overview

In theory the mail class can be easily swapped out - but expecting a replacement to return a PEAR_ERROR is a bit much! This adds handling for exceptions

https://lab.civicrm.org/dev/core/-/issues/2159

Before

PEAR_Error is required on error

After

An exception can be thrown

Technical Details

Mostly in https://lab.civicrm.org/dev/core/-/issues/2159

Comments

• need to think a bit more about the messages though

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

This is kind of related to #18466 and should probably be reviewed in parallel

[monishdeb]

I am happy with the fix. @eileenmcnaughton can you add a unit test which try-catch the expection and assert the error message for using wrong paramter or something else which could result in an exception?

[eileenmcnaughton]

@monishdeb that was a bit of a curly one to write a test for - I wasn't sure for a minute there I could figure it out but I'm happy with the result - as long as jenkins is!

[mattwire]

Linking to #18466

[eileenmcnaughton]

Test fail was because it couldn't serialize my setting (because it had an object in it). I think it's fixed. In terms of how this helps with #18466 - it removes one of the steps en-route to removing ignoreException mode. If we could be sure that we were always throwing exceptions (the thing ignoreException mode messes with) we could be sure that #18466 is safe

[eileenmcnaughton]

@seamuslee001 yay it passed

[seamuslee001]

This makes sense to me and ensures we are generating a consistent return and I did some r-run and confirmed the backtrace didn't seem to change and this functionally ensures that we are returning the same thing if our source threw an Exception or a Pear Error, I'm going to merge this as I think this is a good improvement