Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2028 Add in a status check for checking if the wkhtmltopdf p… #19311

Merged
merged 1 commit into from Jan 6, 2021

Conversation

seamuslee001
Copy link
Contributor

…ackage is installed in the expected location, Also ensure if it isn't then the pdf generation falls back on the current default which is DOMPDF

Overview

As per the lab issue a fatal error can be generated when trying to send out a Participant confirmation if your attaching the PDF onto it and your using wkhtmltopdf according to the settings but the package isn't installed for some reason.

Before

Hard fail on PDF generation

After

Status check and a softer fail with a fallback to using DOMPDF

ping @eileenmcnaughton @demeritcowboy @monishdeb

@civibot
Copy link

civibot bot commented Jan 3, 2021

(Standard links)

@civibot civibot bot added the master label Jan 3, 2021
@seamuslee001 seamuslee001 force-pushed the dev_core_2028 branch 2 times, most recently from 19bbcd6 to 685547f Compare January 3, 2021 21:08
…ackage is installed in the expected location, Also ensure if it isn't then the pdf generation falls back on the current default which is DOMPDF
@demeritcowboy
Copy link
Contributor

  • General standards
    • [r-explain] PASS
    • [r-user] PASS
    • [r-doc] PASS
    • [r-run] PASS
  • Developer standards
    • [r-tech] PASS
    • [r-code] PASS
    • [r-maint] ____
    • [r-test] Pending Pending latest run.

@colemanw
Copy link
Member

colemanw commented Jan 6, 2021

I've always wondered... why do we need to store the path? Can't we look it up with a command like which wkhtmltopdf?

@seamuslee001
Copy link
Contributor Author

@colemanw I presume because which not be on stuff like windows servers or similar or the package may not be in the system PATH

@seamuslee001 seamuslee001 merged commit a1692bf into civicrm:master Jan 6, 2021
@demeritcowboy
Copy link
Contributor

Good thought but it might not be in path. And on windows that would fail.

@seamuslee001 seamuslee001 deleted the dev_core_2028 branch January 6, 2021 00:34
@demeritcowboy
Copy link
Contributor

Oh oh we're starting to think alike.

@mxroo
Copy link

mxroo commented Mar 19, 2021

@mxroo would you be able to do a PR to apply that fix to this file?

Done. #19843

@agileware-justin
Copy link
Contributor

Regression Gitlab, https://lab.civicrm.org/dev/core/-/issues/2478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants