Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php 7.4 compatiblity - Clarify order for nested ternary operator #19354

Merged
merged 1 commit into from Jan 9, 2021

Conversation

demeritcowboy
Copy link
Contributor

Overview

In php 7.4 you need to be more specific about the order when a ? b : c is nested. Also this one has the dot string concatenation operator in there too.

@civibot
Copy link

civibot bot commented Jan 9, 2021

(Standard links)

@civibot civibot bot added the master label Jan 9, 2021
@demeritcowboy
Copy link
Contributor Author

Jenkins retest this please. I think I've seen this before as a flaky test.

api_v3_SyntaxConformanceTest::testCreateSingleValueAlter with data set #82 ('UFField')
api result array comparison failed checking if field_name was correctly updated

Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     'id' => '110'
     'uf_group_id' => '118'
-    'field_name' => 'formatting'
+    'field_name' => 'formatting_6d81'
     'is_active' => '1'
     'is_view' => '0'
     'is_required' => '0'

/home/jenkins/bknix-dfl/build/core-19354-4z4i2/web/sites/all/modules/civicrm/Civi/Test/Api3TestTrait.php:57

@seamuslee001 seamuslee001 merged commit 67f045c into civicrm:master Jan 9, 2021
@demeritcowboy demeritcowboy deleted the php74-more-more branch January 9, 2021 23:16
@demeritcowboy
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants