Deprecate guess work in line item handling #20775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
Test Result (14 failures / +14)CRM_Core_Payment_PayPalIPNTest.testIPNPaymentInputMembershipRecurSuccessCRM_Core_Payment_PayPalIPNTest.testhookAlterIPNDataOnIPNPaymentSuccessCRM_Core_Payment_PayPalIPNTest.testPayPalIPNSuccessDeletedContactCRM_Core_Payment_PayPalProIPNTest.testIPNPaymentRecurSuccessCRM_Core_Payment_PayPalProIPNTest.testIPNPaymentMembershipRecurSuccessCRM_Core_Payment_PayPalProIPNTest.testIPNPaymentCRM13743CRM_Core_Payment_PayPalProIPNTest.testIPNPaymentExpressNoErrorCRM_Core_Payment_PayPalProIPNTest.testIPNPaymentExpressRecurSuccessCRM_Event_BAO_AdditionalPaymentTest.testPaymentWithCustomPaymentInstrumentCRM_Event_BAO_AdditionalPaymentTest.testAddPartialPaymentCRM_Event_BAO_AdditionalPaymentTest.testTransactionInfoCRM_Event_BAO_ChangeFeeSelectionTest.testCRM19273CRM_Event_BAO_ChangeFeeSelectionTest.testCRM21245CRM_Event_BAO_ChangeFeeSelectionTest.testCRM20611 |
eileenmcnaughton
force-pushed
the
loadlines
branch
from
e98d61b
to
aa9aa5f
Compare
|
trying again with fixes from #20784 |
eileenmcnaughton
force-pushed
the
loadlines
branch
from
aa9aa5f
to
9acb42e
Compare
|
This is getting closer! All the remaining issues seem to be invalid test set up in the middle PR |
eileenmcnaughton
force-pushed
the
loadlines
branch
from
9acb42e
to
bafe536
Compare
|
|
eileenmcnaughton
force-pushed
the
loadlines
branch
2 times, most recently
from
5b0c730
to
6fa5898
Compare
|
test this please |
Testing to see how much of this we can deprecate - line items should be 'complete' before reaching the processing function
eileenmcnaughton
force-pushed
the
loadlines
branch
from
6fa5898
to
6644845
Compare
|
Makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Deprecate guess work in line item handling
Before
What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.
After
What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.
Technical Details
If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.
Comments
Anything else you would like the reviewer to note