dev/core#2705 - wrap email message lines

[akosgarai]

Overview

Patch for CORE-2705.
Wrap long lines that could cause invalid DKIM signatures.

Before

If you send an email with lines longer than 1000 characters, the lines are not wrapped.

After

The lines in the email are wrapped after 990 characters.

Technical Details

The wordwrap functionality has been called after the alterMailParams hook has been executed, to prevent the overwrite with the hook. This functionality has been added after every alterMailParam hook call except when the context is messageTemplate, because that hook is called before the tokens are applied.

Comments

I'm not familiar with the flexmailer and the hook is also triggered from there with the flexmailer context. I'm not sure that I put the wrapping logic into the right place. If you could point me to the relevant documentation, that would be welcome.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

hmm @akosgarai we currently apply this patch https://raw.githubusercontent.com/civicrm/civicrm-core/74e25f27bb3be32519657539afe8a285c6c99a08/tools/scripts/composer/patches/mail_mime_crm_3133.patch into the mail_mime package which seems to aimed at doing a similar thing to this PR, that patch is added here https://github.com/pear/Mail_Mime/blob/master/Mail/mime.php#L1529 and just wondering the differences with your code.

[akosgarai]

You are absolutely right @seamuslee001 That patch does exactly the same thing. To be honest, i didn't expect that that it is fixed, due to my find command (find civicrm-core -type f -name "*.php" -exec grep -r -i wordwrap {} \;) didn't gave me results when i searched for the occurrences of the wordwrap string in the civicrm-core codebase. I searched in the php files only not in the composer json, thats why the fix was hidden for me. I will report it back to the issue and also to the original stack exchange question. Should i close this PR?

[eileenmcnaughton]

Yep - let's close this - I guess you got caught out being on an older version?