dev/core#2721 [REF] start unravelling the way we retrieve the saved search #20953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| } | ||
| else { | ||
| $fv = CRM_Contact_BAO_SavedSearch::getFormValues($savedSearchID); |
There was a problem hiding this comment.
In fact I will push this into the following sql functions as a follow up - but it needs to be combined with the line below
eileenmcnaughton
changed the title
| @@ -796,7 +796,10 @@ private static function updateCacheFromTempTable(CRM_Utils_SQL_TempTable $groupC | |||
| */ | |||
| protected static function insertGroupContactsIntoTempTable(string $tempTableName, int $groupID, ?int $savedSearchID, ?string $children): void { | |||
| if ($savedSearchID) { | |||
| $ssParams = CRM_Contact_BAO_SavedSearch::getSearchParams($savedSearchID); | |||
There was a problem hiding this comment.
I've basically copied getSearchParams into the appropriate parts of this function so we can start from a clean array
We have 3 types of saved searches - search kit - legacy core searches - legacy custom searches The only information these 3 need to load is the savedSearch details and the group ID (to add in the add & exclude). The wrangling of the params should happen in the getSql functions - which we can think about being in a listener once they have standard inputs & outputs. However, to get to that point we want to standardise those inputs & outputs. This removes only point of randomness - ie savedSearch has a consistent value & the wrangling of what is in it is pushed closer to the relevant functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#2721 [REF] start unravelling the way we retrieve the saved search
Before
We want to get to the point of passing out a consistent $savedSearch array to the 3 sql functions - but it is already inconsistent when it is retrieved into this function
After
Retrieved consistently. Wrangling closer to where it is used (but still needs some sorting)
Technical Details
We have 3 types of saved searches
The only information these 3 need to load is the savedSearch details and
the group ID (to add in the add & exclude). The wrangling of the params should
happen in the getSql functions - which we can think about being in a listener once
they have standard inputs & outputs. However, to get to that point
we want to standardise those inputs & outputs. This removes
only point of randomness - ie savedSearch has a consistent value & the wrangling
of what is in it is pushed closer to the relevant functions
Comments