Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2740 fix dashboard regression on links #21051

Merged
merged 1 commit into from Aug 7, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

See https://lab.civicrm.org/dev/core/-/issues/2740

Before

When pledge is disabled some dashboard links are wrong

After

Fixed

Technical Details

See https://lab.civicrm.org/dev/core/-/issues/2740

Comments

@civibot
Copy link

civibot bot commented Aug 7, 2021

(Standard links)

@totten
Copy link
Member

totten commented Aug 7, 2021

Tested on with patch on 5.40 -- fixes the problem.

This patch is actually the collaboration of two folks (@twomice and @eileenmcnaughton) and has a +1 form Allen in the Gitlab issue.

Only changes file. Based on grepping, the change is fairly isolated (ie only affects the one screen), so not too concerned about side-effects on other screens.

Merging.

@totten totten merged commit 4d1fe7f into civicrm:master Aug 7, 2021
@totten totten deleted the allan branch August 7, 2021 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants