Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add grid layout support for searchkit #21194

Merged
merged 1 commit into from Aug 20, 2021

Conversation

kurund
Copy link
Contributor

@kurund kurund commented Aug 20, 2021

Overview

  • Add grid display layout for search kit

https://lab.civicrm.org/dev/core/-/issues/2776

@civibot
Copy link

civibot bot commented Aug 20, 2021

(Standard links)

@civibot civibot bot added the master label Aug 20, 2021
@kurund kurund marked this pull request as draft August 20, 2021 14:06
@kurund kurund marked this pull request as ready for review August 20, 2021 14:06
@colemanw
Copy link
Member

(CiviCRM Review Template WORD-1.2)

  • General standards

    • (r-explain) PASS
    • (r-user) PASS
    • (r-doc) We need more docs for searchKit but that shouldn't block this PR
    • (r-run) PASS: New grid display works great.
  • Developer standards

    • (r-tech) PASS: Uses all the new SearchDisplay code patterns.
    • (r-code) PASS
    • (r-maint) PASS
    • (r-test) Search Displays don't have tests but that shouldn't block this PR.

@colemanw
Copy link
Member

@kurund I've tested it out, and given the PR merge-on-pass.

image

One thing I'd like to see, either in a follow-up or in this PR is control over the alignment within cells. I see it's hard-coded to "center" but could be configured with some buttons in the display admin section (fa-align-left, etc)

@kurund
Copy link
Contributor Author

kurund commented Aug 20, 2021

@colemanw

Great thanks.

One thing I'd like to see, either in a follow-up or in this PR is control over the alignment within cells. I see it's hard-coded to "center" but could be configured with some buttons in the display admin section (fa-align-left, etc)

Make sense, will do a follow up PR soon.

@colemanw colemanw merged commit 594db85 into civicrm:master Aug 20, 2021
@eileenmcnaughton
Copy link
Contributor

@kurund - it's really cool to see you contributing a new layout - it would be good if you could add more screenshots to this PR or to th follow up PR / more about how it's useful so I can share that in the dev digest.

As an aside one thing that is already requested for the table layout & I expect would be requested here is the option to have gridlines

@kurund
Copy link
Contributor Author

kurund commented Aug 23, 2021

@eileenmcnaughton

Here is an example of use case: #21225 (comment)

@eileenmcnaughton
Copy link
Contributor

cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants