Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2832 Extend Membership tokens to 'listen' and add test cover #21506

Merged
merged 1 commit into from Sep 17, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

dev/core#2832 Extend Membership tokens to 'listen' and add test cover

Before

Member tokens test cover for legacy method & scheduled reminder & fields synced - but processor was not listening

After

Now listening & tested to be doing so.

Technical Details

Note that the token processor, but not the legacy method, handles custom fields - since the test covers both & compares outcomes some wrangling for that

Comments

@civibot civibot bot added the master label Sep 16, 2021
@civibot
Copy link

civibot bot commented Sep 16, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 @colemanw could one of you merge this? It doesn't change existing functionality it just exposes 'listening' & has oodles of test cover that' I've added

@eileenmcnaughton
Copy link
Contributor Author

I should also note the follow on from this is to update the pdf & email tasks to use it (email doesn't do member tokens yet) so there will be r-run at that point (https://lab.civicrm.org/dev/core/-/issues/1396)

@colemanw
Copy link
Member

This is adding not changing & what is pre-existing had tests pre-added.

@colemanw colemanw merged commit 0736bf3 into civicrm:master Sep 17, 2021
@colemanw colemanw deleted the member_tokens branch September 17, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants