Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Support operators in conditional css rules #22552

Merged
merged 1 commit into from Jan 22, 2022

Conversation

colemanw
Copy link
Member

Overview

SearchKit now allows operators other than = in conditional style rules.

Before

Only = operator supported, pseudofields like row_number not supported.

After

image

Allows operators other than `=` in conditional style rules.
Also supports pseudofields like `row_number`.
@civibot
Copy link

civibot bot commented Jan 18, 2022

(Standard links)

@civibot civibot bot added the master label Jan 18, 2022
@colemanw
Copy link
Member Author

@eileenmcnaughton I believe you requested this in some lab issue somewhere.

@colemanw
Copy link
Member Author

retest this please

@eileenmcnaughton
Copy link
Contributor

hmm tests are failing a lot today

@colemanw
Copy link
Member Author

retest this please

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

@colemanw this is very cool

I did hit one thing - when doing stuff on a field with an option list the value field remains a drop down list of options even when a text box is more appropriate to the operator

image

@colemanw
Copy link
Member Author

@eileenmcnaughton I'm working on fixing the issue you noted, but it's turning into a pretty big refactor to improve the field/operator/value dynamic across SearchKit (in css conditions, link conditions, where/on/having clauses, etc.). IMO we should merge this first, and I'll follow up with a new PR for that work.

@colemanw colemanw merged commit 1f43c7f into civicrm:master Jan 22, 2022
@colemanw colemanw deleted the searchKitConditionalCss branch January 22, 2022 15:10
@colemanw
Copy link
Member Author

@eileenmcnaughton followup PR at #22604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants