Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tokens in offline contribution receipt (new installs) #22560

Merged
merged 1 commit into from
Jan 22, 2022

Commits on Jan 18, 2022

  1. Use tokens in offline receipt

    This gets us away from the empty checks & the isset that causes a crash with smarty modifiers.
    There is no change at the moment as to what is assigned so we don't need to make any changes to existing sites.
    
    The goal is to specify the mappings on the workflow template class later. That will allow
    us to remove significant amounts of code (& leakage points) from the form layer.
    However we still need to resolve civicrm#22547
    because at the moment values in this template expect raw values - which is
    not the case with mapped params at the moment.
    
    Note the biggest thing to contemplate in this PR is the addition of an
    -always-there-in-contribution-smarty-templates smarty value isShowTax.
    The way it is currently checking is that there should pretty much
    be 'something' assigned if invoicing is enabled & it makes sense
    that tax would show even if zero if enabled - which is what I *think*
    is already happening (with maybe some random variation).
    
    I added 'taxTerm' as a domain token and I do kinda prefer that but
    it is available more places (unless we change the audience).
    invoice_notes is another contribution setting that effects display.
    eileenmcnaughton committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    6b892bd View commit details
    Browse the repository at this point in the history