Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Check - Add a reminder about CIVICRM_SIGN_KEYS. #23224

Merged
merged 1 commit into from Apr 20, 2022

Commits on Apr 15, 2022

  1. Overview

    --------
    
    The setting `CIVICRM_SIGN_KEYS` was introduced circa 5.36.  However, it is
    defined in `civicrm.settings.php`, which makes it difficult to reliably
    configure in an automated upgrade.  Consequently, some sites may not have
    this setting, and we must rely on the sysadmin to provide it.
    
    The setting is required for the `crypto.jwt` API (which in turn is used by
    some core extensions, like `authx` and `afform`).
    
    Before
    ------
    
    There is a pre-upgrade message when somebody passes through v5.36.
    
    If you missed the message in 5.36, then you would be unaware of the missing
    setting (until you hit some failure because you use some new/update
    code-path that relies on it).
    
    After
    -----
    
    There is a system status-check.  If you don't have `CIVICRM_SIGN_KEYS`, then
    it will show a link to https://docs.civicrm.org/sysadmin/en/latest/setup/secret-keys/.
    totten committed Apr 15, 2022
    Copy the full SHA
    81e3a0d View commit details
    Browse the repository at this point in the history