dev/core#3778 Add code hook to set civicrm_participant.created_id

[mattwire]

Overview

This extracts the part of #23936 that populates the created_id field.

Before

civicrm_participant.created_id not populated.

After

civicrm_participant.created_id populated.

Technical Details

Set the "created_id" field.
The created_id should always be the person that actually did the registration.
That might be the first participant, but it might be someone registering someone without registering themselves.

1. Prefer logged in contact id
2. Fall back to 'registered_by_id' param.
3. Fall back to participant contact_id (for anonymous person registering themselves)

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

looks good but perhaps this should be !empty since I don't think we are encouraging NULL

[mattwire]

@eileenmcnaughton Makes sense. I've updated the PR to check if the field is empty() so that we set the field if it has not been set, or is set to NULL.

[eileenmcnaughton]

This check is redundant now - same as above

[mattwire]

@eileenmcnaughton No. Because we probably set it in the line above to the logged in contact ID (step 1). The other two conditions are only triggered if the created_id is still empty

[eileenmcnaughton]

ok right

[eileenmcnaughton]

I think this is mergeable with just one minor further fix - the empty() check is the same in the main if as the later if so it is redundant

[colemanw]

Ideally the unit test would cover all 3 scenarios (get from logged in user, get from registered_by_id, and explicitly provided value passed in).